Fix publish package workflow #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
commented
Oct 16, 2023
|
|
||
| <SolutionProjects Remove="docs\**\**\*.csproj" /> | ||
| <SolutionProjects Remove="examples\**\*.csproj" /> | ||
| <SolutionProjects Remove="test\Benchmarks\Benchmarks.csproj" /> |
There was a problem hiding this comment.
We could actually just skip building the test projects altogether when running the publish package workflow. For now, I would like to just get this PR merged to unblock 1.7.0-alpha.1 release.
vishweshbankwar
approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #4954 +/- ##
==========================================
- Coverage 83.42% 83.38% -0.04%
==========================================
Files 295 295
Lines 12360 12360
==========================================
- Hits 10311 10307 -4
- Misses 2049 2053 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
docs/andOpenTelemetry.Exporter.Zipkin.Testsas they have a project dependency on instrumentation libraries