[sdk-logs] Add LoggerProviderBuilderSdk to SDK #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
utpilla
reviewed
Apr 26, 2023
| public readonly string Version; | ||
| public readonly object Instance; | ||
|
|
||
| internal InstrumentationRegistration(string name, string version, object instance) |
There was a problem hiding this comment.
Not related to this PR but could we share this struct among the different provider SDKs?
There was a problem hiding this comment.
Totally. Or just remove it, I don't think we use this data for anything?
utpilla
approved these changes
Apr 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4447 +/- ##
==========================================
- Coverage 84.64% 84.41% -0.23%
==========================================
Files 309 310 +1
Lines 12248 12281 +33
==========================================
Hits 10367 10367
- Misses 1881 1914 +33
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
LoggerProviderBuilderSdkto SDK.Merge requirement checklist