Add comment and compare Activity.Current to IHttpFeatureActivityFeatu…

…re activity
open-telemetry · Dec 8, 2023 · 98c8feb · 98c8feb
1 parent 0e26e0b
commit 98c8feb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs b/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs
@@ -1053,6 +1053,8 @@ public async Task NoSiblingActivityCreatedWhenTraceFlagsNone()
         var result = bool.Parse(await response.Content.ReadAsStringAsync());
 
         Assert.True(response.IsSuccessStatusCode);
+
+        // Confirm that Activity.Current and IHttpActivityFeature activity are same
         Assert.True(result);
     }
 #endif

diff --git a/test/TestApp.AspNetCore/Controllers/ChildActivityController.cs b/test/TestApp.AspNetCore/Controllers/ChildActivityController.cs
@@ -41,7 +41,7 @@ public IReadOnlyDictionary<string, string> GetChildActivityBaggageContext()
     public bool GetActivityEquality()
     {
         var activity = this.HttpContext.Features.GetRequiredFeature<IHttpActivityFeature>().Activity;
-        var equal = Activity.Current?.Id == activity.Id;
+        var equal = Activity.Current == activity;
         return equal;
     }
 }