-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Add net8.0 target for GenevaExporter #1463
[Exporter.Geneva] Add net8.0 target for GenevaExporter #1463
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
+ Coverage 73.91% 74.35% +0.43%
==========================================
Files 267 262 -5
Lines 9615 9806 +191
==========================================
+ Hits 7107 7291 +184
- Misses 2508 2515 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -16,6 +16,7 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="OpenTelemetry" Version="$(OTelSdkVersion)" /> | |||
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.0.0" Condition="'$(TargetFramework)' == 'net462'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 1.7.0-rc.1
version of the SDK, this package now pulls in 8.0.0
version of Microsoft.Extensions.Logging.Configuration
instead of 3.1.0
version that used to come with the previous dependency.
Microsoft.Extensions.Logging.Configuration
has added a dedicated net462 target in 8.0.0
which does not have the RuntimeInformation
library included. That's why we need an explicit package dependency for net462
targets now. With 3.1.0
version, there was no dedicated net462
target, and the package ended up using netstandard2.0
bits which includes the RuntimeInformation
package.
Follow this discussion for more details: open-telemetry/opentelemetry-dotnet#5020 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -117,7 +125,7 @@ public override unsafe int GetChars(byte* bytePtr, int byteCount, char* charPtr, | |||
return byteCount; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this line is not needed I guess?
Changes
1.7.0-rc.1
CHANGELOG.md
updated for non-trivial changes