Skip to content

Commit

Permalink
[TEST] Rename w3c_tracecontext_test to w3c_tracecontext_http_test_ser…
Browse files Browse the repository at this point in the history
…ver (#3132)
  • Loading branch information
psx95 authored Nov 8, 2024
1 parent 24a523c commit 1863fe7
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -946,8 +946,8 @@ jobs:
CXX_STANDARD: '14'
run: |
./ci/do_ci.sh cmake.w3c.trace-context.build-server
cd $HOME/build/ext/test/w3c_tracecontext_test
./w3c_tracecontext_test &
cd $HOME/build/ext/test/w3c_tracecontext_http_test_server
./w3c_tracecontext_http_test_server &
- name: Checkout w3c/trace-context repo
uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion ext/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@

add_subdirectory(http)
if(BUILD_W3CTRACECONTEXT_TEST)
add_subdirectory(w3c_tracecontext_test)
add_subdirectory(w3c_tracecontext_http_test_server)
endif()
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SPDX-License-Identifier: Apache-2.0

cc_binary(
name = "w3c_tracecontext_test",
name = "w3c_tracecontext_http_test_server",
srcs = [
"main.cc",
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@

include_directories(${CMAKE_SOURCE_DIR}/exporters/ostream/include)

add_executable(w3c_tracecontext_test main.cc)
add_executable(w3c_tracecontext_http_test_server main.cc)
target_link_libraries(
w3c_tracecontext_test
w3c_tracecontext_http_test_server
PRIVATE ${CMAKE_THREAD_LIBS_INIT} opentelemetry_trace
opentelemetry_http_client_curl opentelemetry_exporter_ostream_span
${CURL_LIBRARIES} nlohmann_json::nlohmann_json)
if(nlohmann_json_clone)
add_dependencies(w3c_tracecontext_test nlohmann_json::nlohmann_json)
add_dependencies(w3c_tracecontext_http_test_server
nlohmann_json::nlohmann_json)
endif()
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ instructions](https://github.com/w3c/trace-context/tree/master/test#implement-te
1: Build and start the test service endpoint:

```sh
./w3c_tracecontext_test
./w3c_tracecontext_http_test_server

Listening to http://localhost:30000/test
```

A custom port number for the test service to listen to can be specified:

```sh
./w3c_tracecontext_test 31339
./w3c_tracecontext_http_test_server 31339

Listening to http://localhost:31339/test
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void initTracer()
nostd::shared_ptr<trace_api::Tracer> get_tracer()
{
auto provider = trace_api::Provider::GetTracerProvider();
return provider->GetTracer("w3c_tracecontext_test");
return provider->GetTracer("w3c_tracecontext_http_test_server");
}

struct Uri
Expand Down

1 comment on commit 1863fe7

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1863fe7 Previous: 24a523c Ratio
BM_SpinLockThrashing/1/process_time/real_time 0.23878188360305058 ms/iter 0.10080660803843353 ms/iter 2.37
BM_SpinLockThrashing/2/process_time/real_time 0.5430159152754201 ms/iter 0.2021891470173843 ms/iter 2.69
BM_SpinLockThrashing/4/process_time/real_time 1.7444729804992676 ms/iter 0.7441231093481573 ms/iter 2.34
BM_NaiveSpinLockThrashing/2/process_time/real_time 0.3821908588140783 ms/iter 0.18041034405837952 ms/iter 2.12

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.