Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetricReader invalid configurations #148

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix MetricReader invalid configurations #148

merged 2 commits into from
Dec 9, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 5, 2024

Fixes #138

  • Move producers from MetricReader to PeriodicMetricReader
  • Move producers from MetricReader to PullMetricReader

@marcalff marcalff requested a review from a team as a code owner December 5, 2024 22:36
@marcalff marcalff changed the title Fixes #138 Fix MetricReader invalid configurations Dec 5, 2024
jack-berg
jack-berg approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better way to model this. There's little / no advantage to having the producers a property of MetricReader vs. PeriodicMetricReader / PullMetricReader.

Thanks!

@jack-berg jack-berg merged commit f97328f into open-telemetry:main Dec 9, 2024
11 checks passed
@brettmc brettmc mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MetricReader allows invalid configurations
2 participants
@marcalff @jack-berg