Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Refactor telemetry initialization #9320

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 19, 2024

Description:

A part of #9319 that can be done without waiting for #9131

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 19, 2024
@mx-psi mx-psi requested review from codeboten and a team January 19, 2024 16:22
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (72f6ce1) 90.34% compared to head (d00d17d) 90.33%.

Files Patch % Lines
service/service.go 66.66% 2 Missing and 1 partial ⚠️
service/telemetry.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9320      +/-   ##
==========================================
- Coverage   90.34%   90.33%   -0.02%     
==========================================
  Files         340      341       +1     
  Lines       17989    17986       -3     
==========================================
- Hits        16253    16248       -5     
- Misses       1412     1414       +2     
  Partials      324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. WDYT of adding a config_test.go file in the internal resource package?

@mx-psi
Copy link
Member Author

mx-psi commented Jan 19, 2024

Thanks for cleaning this up. WDYT of adding a config_test.go file in the internal resource package?

Done!

@codeboten codeboten merged commit 4d73b4f into open-telemetry:main Jan 22, 2024
30 of 31 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 22, 2024
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants