Introduce Equal
comparison in pcommon types
#12568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces
.Equal()
methods to most pcommon types, so equality comparison can be performed with no allocations.The types
Equal
is added to are:Value
ByteSlice
Float64Slice
Int32Slice
Int64Slice
StringSlice
Uint64Slice
Map
Slice
The original intent was to add it to
Value
. However, to be able to handle every type in there, I had to also add it to the other types, some of which are coming too because they are auto-generated.Link to tracking issue
Fixes #12561
Testing
Here are the results from the new benchmarks.