Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add release:risky-change on PRs touching certain files #12552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Mar 4, 2025

Description

This modifies the "Add code owners to a PR" CI workflow, which automatically adds component-related labels to PRs, to also add the "release:risky-change" label if the PR touches a hard-coded list of files. Currently, this list is:

Makefile
Makefile.Common
.github/workflows/prepare-release.yml
.github/workflows/scripts/release-prepare-release.sh

I also specified the C locale in the tr command which gets the PR data. It probably won't matter in the Ubuntu-based CI, but I had issues with the Homebrew core-utils version of tr when testing locally. I can remove this change if you think it's unnecessary.

Link to tracking issue

Fixes #11857

Testing

I did some dry runs locally with a few PRs that did or did not touch the relevant files.

@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner March 4, 2025 17:15
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (a8b2be1) to head (b1b3e60).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12552      +/-   ##
==========================================
- Coverage   92.22%   92.18%   -0.04%     
==========================================
  Files         469      469              
  Lines       25323    25395      +72     
==========================================
+ Hits        23353    23410      +57     
- Misses       1563     1574      +11     
- Partials      407      411       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the title of the CI job and the script to reflect the expanded scope?

@jade-guiton-dd
Copy link
Contributor Author

Yeah that makes sense.

@jade-guiton-dd
Copy link
Contributor Author

jade-guiton-dd commented Mar 5, 2025

I also renamed the add-labels job to add-labels-command to differentiate the manual /label job from the automatic label addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically label release-affecting changes
2 participants