Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Add namespace parameter to component.BuildInfo #12508

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dpaasman00
Copy link
Contributor

Description

Adds a new field to component.BuildInfo to facilitate support for reporting the service.namespace semantic convention in OpAMP. Includes corresponding updates to resource attributes reported by the collector. Also adds a new parameter to the builder configuration to facilitate setting this via the OCB.

Link to tracking issue

Fixes #12505

Need follow up PR to OpAMP extension making use of this value.

Testing

Relevant unit tests updated.

Running the updated otelcorecol with logging enabled in service.telemetry and the new resource attribute for service.namespace shows up. This was done sending to another collector running the otlp receiver and logging via the debug exporter.

02-26-25_monitoring-output.txt

Documentation

@dpaasman00 dpaasman00 requested a review from a team as a code owner February 26, 2025 20:21
@dpaasman00 dpaasman00 requested a review from atoulme February 26, 2025 20:21
@dpaasman00 dpaasman00 force-pushed the dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb branch from 10a0443 to 832d433 Compare February 26, 2025 20:28
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (df36fd7) to head (b3427b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12508      +/-   ##
==========================================
+ Coverage   92.18%   92.20%   +0.02%     
==========================================
  Files         469      469              
  Lines       25395    25400       +5     
==========================================
+ Hits        23410    23421      +11     
+ Misses       1574     1568       -6     
  Partials      411      411              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpaasman00 dpaasman00 changed the title add namespace parameter to component.BuildInfo [component] Add namespace parameter to component.BuildInfo Feb 27, 2025
@dpaasman00 dpaasman00 force-pushed the dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb branch from a0aced7 to 0e8b029 Compare February 27, 2025 18:09
@dpaasman00 dpaasman00 force-pushed the dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb branch from 742e731 to d5a3432 Compare March 3, 2025 12:11
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

@dpaasman00 dpaasman00 force-pushed the dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb branch from 9e2fe4e to b3427b6 Compare March 5, 2025 18:31
@dpaasman00 dpaasman00 requested a review from evan-bradley March 5, 2025 18:31
@evan-bradley evan-bradley added the ready-to-merge Code review completed; ready to merge by maintainers label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component] Add service.namespace semantic convention to component.BuildInfo
4 participants