-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component] Add namespace parameter to component.BuildInfo #12508
Open
dpaasman00
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
observIQ:dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[component] Add namespace parameter to component.BuildInfo #12508
dpaasman00
wants to merge
6
commits into
open-telemetry:main
from
observIQ:dakotapaasman/bpop-2116-configurable-servicenamespace-value-in-ocb
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10a0443
to
832d433
Compare
iblancasa
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12508 +/- ##
==========================================
+ Coverage 92.18% 92.20% +0.02%
==========================================
Files 469 469
Lines 25395 25400 +5
==========================================
+ Hits 23410 23421 +11
+ Misses 1574 1568 -6
Partials 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0aced7
to
0e8b029
Compare
djaglowski
approved these changes
Feb 27, 2025
742e731
to
d5a3432
Compare
evan-bradley
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
9e2fe4e
to
b3427b6
Compare
evan-bradley
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new field to
component.BuildInfo
to facilitate support for reporting theservice.namespace
semantic convention in OpAMP. Includes corresponding updates to resource attributes reported by the collector. Also adds a new parameter to the builder configuration to facilitate setting this via the OCB.Link to tracking issue
Fixes #12505
Need follow up PR to OpAMP extension making use of this value.
Testing
Relevant unit tests updated.
Running the updated otelcorecol with logging enabled in
service.telemetry
and the new resource attribute forservice.namespace
shows up. This was done sending to another collector running the otlp receiver and logging via the debug exporter.02-26-25_monitoring-output.txt
Documentation