-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline ID to the error message for unused connectors. #12410
Add pipeline ID to the error message for unused connectors. #12410
Conversation
bfa89c4
to
b043489
Compare
a3130ef
to
a3fc63c
Compare
Thank you so much for your quick response and amazing suggestions. I have made the adjustment, let me know how it looks @bogdandrutu |
a3fc63c
to
372ab66
Compare
372ab66
to
9faed07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12410 +/- ##
=======================================
Coverage 92.09% 92.10%
=======================================
Files 465 465
Lines 25173 25180 +7
=======================================
+ Hits 23184 23191 +7
Misses 1592 1592
Partials 397 397 ☔ View full report in Codecov by Sentry. |
Head branch was pushed to by a user without write access
@bogdandrutu Thanks for approving the PR earlier. I added a |
Description
As mentioned in this #8721 (comment), the error message for unused connectors currently lacks specific pipeline names, making debugging more difficult.
This PR enhances the error message by including pipeline names in the
[signal/name]
format, consistent with how they appear inconfig.yaml
. This provides a better context for identifying misconfigurations.Link to tracking issue
Related to #8721
Testing
A few scenarios and example output are given below. I will do additional testing and add unit tests if necessary.
1. Used as a receiver but not used as an exporter with 1 signal
config.yaml
Main Branch Output:
Proposed Output:
2. Plain
config.yaml
Main Branch Output:
Proposed Output:
3. Multiple pipeline
config.yaml
Main Branch Output:
Proposed Output: