[chore] Move LoggerWithout temporarily to internal package #12334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
added
the
release:blocker
bogdandrutu
reviewed
Feb 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12334 +/- ##
==========================================
+ Coverage 91.45% 91.49% +0.04%
==========================================
Files 467 466 -1
Lines 25613 25612 -1
==========================================
+ Hits 23424 23434 +10
+ Misses 1785 1774 -11
Partials 404 404 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Feb 11, 2025
bogdandrutu
approved these changes
Feb 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follow up to #12334 to do step 5 of https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/coding-guidelines.md#module-organization Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves
LoggerWithoutto an internal package so that we can keep on experimenting on it while mark component 1.0 on v0.121.0.This does not need a changelog since the change has not been released
Link to tracking issue
Updates #12217