[xconfmap] Create module and add validation facilities #12226
Merged
+690
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#12224 is merged, so this PR only contains relevant changes now. |
evan-bradley
commented
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12226 +/- ##
==========================================
+ Coverage 91.27% 91.31% +0.03%
==========================================
Files 466 467 +1
Lines 25583 25711 +128
==========================================
+ Hits 23351 23477 +126
- Misses 1816 1818 +2
Partials 416 416 ☔ View full report in Codecov by Sentry. |
evan-bradley
force-pushed
the
create-confmap-validate
branch
from
aa1b14c to
65dd4cd
Compare
evan-bradley
changed the title
evan-bradley
changed the title
evan-bradley
commented
Feb 4, 2025
| const ( | ||
| // MapstructureTag is the struct field tag used to record marshaling/unmarshaling settings. | ||
| // See https://pkg.go.dev/github.com/go-viper/mapstructure/v2 for supported values. | ||
| MapstructureTag = "mapstructure" |
There was a problem hiding this comment.
We could just hardcode the tag name in xconfmap for now, but I figure it's a good time to make this an exported constant.
There was a problem hiding this comment.
We could also move this to an confmap/internal package I guess, if we want to avoid exposing this
mx-psi
approved these changes
Feb 4, 2025
bogdandrutu
approved these changes
Feb 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR is to unblock `make update-otel` in contrib repo cc @evan-bradley @mx-psi <!-- Issue number if applicable --> #### Link to tracking issue Relevant #12226 <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on #12224 and starts the move of config validation from component to confmap. We can keep this in
xconfmapwhile we determine whether to add the ability to validate using struct field tags.I think this has the following advantages:
The one uncertainty this creates is what to do withcomponent.Config, which would now be used as a thin alias foranywithout any meaningful usage in component.Link to tracking issue
Fixes #11524