Change receiver shared component part #12203
Conversation
Signed-off-by: Bogdan Drutu <[email protected]>
| return grpcs.LoadOrStore( | ||
| cfg, | ||
| func() (*grpcComponent, error) { | ||
| return &grpcComponent{cfg: cfg, tel: tel}, nil |
There was a problem hiding this comment.
When you pass in tel here, I assume you want it to not have an otel.signal attribute on the logger, etc?
This still leaves us in a situation where it needs to be present sometimes and not others. What's the mechanism for managing this?
There was a problem hiding this comment.
Also, when the server encounters an error, the metrics handler will have to use the signal-agnostic logger anyways, so doesn't it then have to use zap.String(...) anyways to append the signal attribute?
There was a problem hiding this comment.
My hope is that, now that we know a component has to create different "types" of sub-component, the mechanism we design will allow that. Very important is that the "main" component still has all the "attributes".
The easiest way I can think of is via the TelemetrySettings we provide, we can have there a mechanism of retrieving the Logger via some functions instead of direct access to 1 variable.
No description provided.