Update module github.com/cenkalti/backoff/v4 to v5 #11989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
mx-psi,
dmathieu,
a team,
evan-bradley,
dmitryax and
andrzej-stencel
as code owners
bogdandrutu
force-pushed
the
updatebackf
branch
2 times, most recently
from
8de667d to
6757736
Compare
bogdandrutu
force-pushed
the
updatebackf
branch
from
6757736 to
f31015c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11989 +/- ##
==========================================
- Coverage 91.55% 91.54% -0.02%
==========================================
Files 467 467
Lines 25652 25657 +5
==========================================
+ Hits 23485 23487 +2
- Misses 1768 1770 +2
- Partials 399 400 +1 ☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
force-pushed
the
updatebackf
branch
from
f31015c to
adca17d
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
updatebackf
branch
from
adca17d to
758175a
Compare
atoulme
reviewed
Feb 18, 2025
| @@ -111,7 +111,13 @@ func (rs *retrySender) Send(ctx context.Context, req request.Request) error { | |||
| backoffDelay = max(backoffDelay, throttleErr.delay) | |||
| } | |||
|
|
|||
| if deadline, has := ctx.Deadline(); has && time.Until(deadline) < backoffDelay { | |||
| nextRetryTime := time.Now().Add(backoffDelay) | |||
| if !maxElapsedTime.IsZero() && maxElapsedTime.Before(nextRetryTime) { | |||
There was a problem hiding this comment.
is this a separate bug? Is it covered by tests?
There was a problem hiding this comment.
There was a problem hiding this comment.
V5 does not have this logic supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.