[extension/zpages] Add an option to enable expvar #11964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve open-telemetry#11081 Signed-off-by: Hong Chen <[email protected]>
Signed-off-by: Hong Chen <[email protected]>
Signed-off-by: Hong Chen <[email protected]>
Signed-off-by: Hong Chen <[email protected]>
Signed-off-by: Hong Chen <[email protected]>
yurishkuro
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11964 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 467 467
Lines 25618 25622 +4
=======================================
+ Hits 23451 23455 +4
Misses 1768 1768
Partials 399 399 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hong Chen <[email protected]>
|
Hi @atoulme , could you help to review this PR? Thanks! |
atoulme
reviewed
Jan 18, 2025
atoulme
reviewed
Jan 18, 2025
atoulme
reviewed
Jan 18, 2025
Signed-off-by: Hong Chen <[email protected]>
atoulme
approved these changes
Jan 18, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi @yurishkuro @atoulme , seems this PR is marked stale, could you help to see this PR if is mergable? |
yurishkuro
approved these changes
Feb 4, 2025
yurishkuro
added
the
ready-to-merge
bogdandrutu
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to enable expvar, default is
disable.Link to tracking issue
Resolve #11081
Testing
Add a test case to verify the newly added option works.