-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/mdatagen]: Add feature gates support to metadata-schema.yaml #11466
base: main
Are you sure you want to change the base?
[cmd/mdatagen]: Add feature gates support to metadata-schema.yaml #11466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments
7514949
to
05ec7bf
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (55.88%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11466 +/- ##
==========================================
- Coverage 91.77% 91.72% -0.05%
==========================================
Files 462 462
Lines 24886 24920 +34
==========================================
+ Hits 22840 22859 +19
- Misses 1664 1677 +13
- Partials 382 384 +2 ☔ View full report in Codecov by Sentry. |
95dc2e8
to
68b465a
Compare
7ffa5a0
to
32f20c5
Compare
b9a675b
to
50d5cf3
Compare
Can you fix the merge conflict? The CI won't run otherwise |
27d1ad9
to
a482d76
Compare
done |
7daa444
to
b63861b
Compare
Co-authored-by: Pablo Baeyens <[email protected]>
b63861b
to
01e73a2
Compare
@mx-psi PTAL |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@mx-psi PTAL |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@mx-psi PTAL |
@mx-psi PTAL |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
Added feature-gates section to metadata-schema.yaml together with id, description, stage and other required. This information can then be used for code generation, documentation generation and by other consumers of the metadata.yaml file
Link to tracking Issue: #9860