Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configtelemetry] add guidelines for each level of config telemetry #10365

Merged
merged 22 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/add_guidelines_telemetry.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: configtelemetry

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add guidelines for each level of component telemetry

# One or more tracking issues or pull requests related to the change
issues: [10286]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
39 changes: 39 additions & 0 deletions config/configtelemetry/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,43 @@
// Package configtelemetry defines various telemetry level for configuration.
// It enables every component to have access to telemetry level
// to enable metrics only when necessary.
//
// This document provides guidance on which telemetry level to adopt for Collector metrics.
// When adopting a telemetry level, the developer is expected to rely on this guidance to
atoulme marked this conversation as resolved.
Show resolved Hide resolved
// justify their choice of telemetry level.
//
// 1. configtelemetry.None
//
// No telemetry data should be collected.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// 2. configtelemetry.Basic
//
// Signals associated with this level provide the essential coverage of the collector telemetry.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
// It should only be used for internal collector telemetry generated by the collector core API. Components SHOULD NOT use this level to report additional metrics.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// 3. configtelemetry.Normal
//
// Signals associated with this level cover the complete coverage of the component telemetry.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
// It should be the default for component authors.
//
// Signals using this telemetry level can use this guidance:
atoulme marked this conversation as resolved.
Show resolved Hide resolved
// - The signals associated with this level must control cardinality.
// It is acceptable at this level for cardinality to scale linearly with the monitored resources.
// - The signals associated with this level must represent a controlled data volume. Examples follow:
// - A max cardinality (total possible combinations of dimension values) of 500.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
atoulme marked this conversation as resolved.
Show resolved Hide resolved
// - At most 5 spans actively recording simultaneously.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
atoulme marked this conversation as resolved.
Show resolved Hide resolved
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// This is the default level recommended when running the Collector.
//
// * All signals defined in the component telemetry are active.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// 4. configtelemetry.Detailed
//
// Signals associated with this level cover the complete coverage of the component telemetry.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// The signals associated with this level may exhibit high cardinality.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
//
// There is no limit on data volume.
//
// All signals defined in the component telemetry are active.
atoulme marked this conversation as resolved.
Show resolved Hide resolved
package configtelemetry // import "go.opentelemetry.io/collector/config/configtelemetry"
Loading