Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Equal() helper method to pcommon.Value #12561

Open
dmathieu opened this issue Mar 5, 2025 · 0 comments · May be fixed by #12568
Open

Add Equal() helper method to pcommon.Value #12561

dmathieu opened this issue Mar 5, 2025 · 0 comments · May be fixed by #12568
Assignees
@dmathieu

Comments

@dmathieu
Copy link
Member

dmathieu commented Mar 5, 2025 •
edited
Loading 

          nit: I know that `AsRaw()` could make a copy of the data. This is a reminder that it would be nice if you could write `a.Value().Equal(value)` and avoid the allocation.

Originally posted by @jmacd in #12390 (comment)

So we don't need to use AsRaw to do value comparison.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmathieu dmathieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce Equal comparison in pcommon types dmathieu/opentelemetry-collector
1 participant
@dmathieu