[chore] Update types used in extensiontest.NewNopSettingsWithType #37844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sincejune
requested review from
evan-bradley,
tigrannajaryan,
a team,
dmitryax and
ChrsMark
as code owners
mx-psi
approved these changes
Feb 11, 2025
yiquanzhou
added a commit
to dash0hq/opentelemetry-collector-contrib
that referenced
this pull request
Feb 11, 2025
* main: (76 commits) Update All OpenTelemetry Collector Contrib packages (open-telemetry#37839) [chore] fix codeowners allowlist (open-telemetry#37856) Update module github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp to v1.26.0 (open-telemetry#37841) Update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1095 (open-telemetry#37825) Update module github.com/grpc-ecosystem/grpc-gateway/v2 to v2.26.1 (open-telemetry#37821) [chore][exporter/elasticsearch] Bump go-docappender to v2.5.0 (open-telemetry#37852) Update All github.com/aws packages (open-telemetry#37816) Update module google.golang.org/protobuf to v1.36.5 (open-telemetry#37827) Update module github.com/SAP/go-hdb to v1.12.12 (open-telemetry#37817) Update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.135 (open-telemetry#37822) Update module github.com/ClickHouse/clickhouse-go/v2 to v2.31.0 (open-telemetry#37835) [receiver/datadog] Implement support for span links (open-telemetry#37449) receiver/prometheusreceiver: allow cumulative resets when using the adjuster (open-telemetry#37718) Update README.md (open-telemetry#37826) [receiver/github] add workflow run event trace handling (open-telemetry#37578) Update All github.com/datadog packages to v0.62.2 (open-telemetry#37838) [chore] Update types used in extensiontest.NewNopSettingsWithType (open-telemetry#37844) [processor/redaction] introduce `allowed_values` parameter in processor config (open-telemetry#37638) [chore] Update otel version (open-telemetry#37808) [testbed] Include CPU and memory limits to benchmark results file (open-telemetry#36753) ...
khushijain21
pushed a commit
to khushijain21/opentelemetry-collector-contrib
that referenced
this pull request
Feb 14, 2025
…en-telemetry#37844) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR replaced `extensiontest.NopType` with actual factory type if it's created. cc @mx-psi <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Follow up PR of open-telemetry#37808 <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaced
extensiontest.NopTypewith actual factory type if it's created. cc @mx-psiLink to tracking issue
Follow up PR of #37808
Testing
n/a
Documentation
n/a