Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] make tidylist #37170

Closed

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Jan 13, 2025

Description

The new CI job checking that internal/tidylist/tidylist.txt is up-to-date, introduced in #37142, is failing on main because #36838 which was merged just before causes changes to said file. This PR just runs make tidylist to fix this.

@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner January 13, 2025 15:56
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jan 13, 2025
@TylerHelmuth
Copy link
Member

@jade-guiton-dd there are more files that need added, needs another make tidylist.

TylerHelmuth added a commit that referenced this pull request Jan 13, 2025
…37173)

Reverts
#37142
as something with this change is not working as expected. Reverting for
now to unblock PRs.

See
#37170
and
#37172
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
…etry#37142)" (open-telemetry#37173)

Reverts
open-telemetry#37142
as something with this change is not working as expected. Reverting for
now to unblock PRs.

See
open-telemetry#37170
and
open-telemetry#37172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants