Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Spelling exporter #37133

Merged
merged 116 commits into from
Jan 17, 2025
Merged

[chore] Spelling exporter #37133

merged 116 commits into from
Jan 17, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 10, 2025

Description

Fix spelling in exporter/
#37128 (review)

Link to tracking issue

jsoref added 30 commits January 10, 2025 00:52
@jsoref
spelling: add
2fcbed5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: aggregated
9265414 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: aggregates
fb96227 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: aggregations
e1c7bca 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: alternate
f2672e2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: ambiguous
47e54ba 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: and
846d70f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: annotation
f289dfa 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: applicable
84ebc21 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attribute
7909acc 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attributes
53432a0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: batch
dbc6ae1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: be
bdee575 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: builder
f1582c3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cannot
cf2a16e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: case-sensitive
7e43bfd 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: collisions
5d9a544 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: connections
7d1d008 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: consider
fe9d4b0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: constituent
ac04031 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: consumer
02ba0b0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: content
5464a68 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: corresponding
221ec68 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: creator-on
26c656e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: current
0284a8a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: datadog
a40ac8e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: datapoint
9bef021 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: delta
9455c7b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: descriptor
a92993f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: deterministically
28fb631 
Signed-off-by: Josh Soref <[email protected]>
crobert-1
crobert-1 reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, really appreciate all of the fixes!

Note: One thing that concerns me is when metric or attributes names are changed to fix typos as it may break existing functionality, but in this PR it looks like it's all test code, where a test is writing and then checking a typo. I think this PR is fine on that front.

exporter/azuredataexplorerexporter/README.md Outdated Show resolved Hide resolved
exporter/azuremonitorexporter/README.md Show resolved Hide resolved
exporter/prometheusexporter/README.md Outdated Show resolved Hide resolved
exporter/signalfxexporter/README.md Outdated Show resolved Hide resolved
exporter/signalfxexporter/README.md Outdated Show resolved Hide resolved
exporter/splunkhecexporter/README.md Outdated Show resolved Hide resolved
exporter/splunkhecexporter/README.md Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the spelling-exporter branch from f1a5b49 to e0aa04c Compare January 10, 2025 17:43
jsoref added 15 commits January 14, 2025 15:21
@jsoref
link: exporter documentation
5568927 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: exporterhelper configuration parameters
cd94fe0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: exporterhelper
6edb828 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: full list of ServerConfig options
f892252 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: grpc's
6c29b51 
naming.md

Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: how to configure the OpenTelemetry integration
edd52f7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: how to send logs to Grafana Loki using the OpenTelemetry Collector
042baf5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: interface for a Sentry Transaction
4810405 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: proxy support
f509e4a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: resourcemapping.go
513de9d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: signalfx/sapm-proto
466cf24 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: trace_to_envelope.go
29b633e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: moving the Sumo Logic exporter into this repository
56506c0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: config.go
236bd6e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
link: testdata/config.yaml
043cfa8 
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref force-pushed the spelling-exporter branch from e0aa04c to 043cfa8 Compare January 14, 2025 20:23
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Jan 17, 2025
@songy23 songy23 merged commit c506f54 into open-telemetry:main Jan 17, 2025
174 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@jmacd jmacd jmacd approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees

@atoulme atoulme

Labels
exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/doris exporter/elasticsearch exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logzio exporter/loki Loki Exporter exporter/opencensus exporter/opensearch exporter/otelarrow exporter/prometheus exporter/prometheusremotewrite exporter/rabbitmq exporter/sapm exporter/sentry exporter/signalfx exporter/splunkhec exporter/sumologic ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @jmacd @songy23 @crobert-1 @atoulme