[chore] Fix logzioexporter tests on Windows #37066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
added
Skip Changelog
songy23
approved these changes
Jan 7, 2025
crobert-1
approved these changes
Jan 7, 2025
dmitryax
approved these changes
Jan 7, 2025
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
#### Description The test doesn't account that depending on `git` config the endlines of the test files may change from `\n` to `\r\n`. Alternatively we could require/document how `core.autocrlf` should be configured for the repo, but, doing it on code ensures that works with any configuration. This fixes test failures on `TestFromDomainEmbedProcess`, e.g.: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12651645455/job/35252663284#step:8:478 #### Testing Local run. #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test doesn't account that depending on
gitconfig the endlines of the test files may change from\nto\r\n. Alternatively we could require/document howcore.autocrlfshould be configured for the repo, but, doing it on code ensures that works with any configuration.This fixes test failures on
TestFromDomainEmbedProcess, e.g.: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12651645455/job/35252663284#step:8:478Testing
Local run.
Documentation
N/A