Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][connector/routing] Add pmetricutil.MoveDataPointsWithContextIf #36521

Closed

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Nov 25, 2024

This enhances the internal pmetricutil and pmetricutiltest packages to support routing by data points. There is quite a lot of duplicated code to support the various types of metrics, but otherwise it is essentially the same pattern as used in all other recent routing work.

It does NOT go as far as adding routing by data point support to the connector. This will be done in a followup PR.

@github-actions github-actions bot requested review from jpkrohling and mwear November 25, 2024 16:19
@djaglowski djaglowski force-pushed the routing-by-datapoints branch 2 times, most recently from 4c84080 to 5a12ed4 Compare November 25, 2024 16:50
@djaglowski djaglowski force-pushed the routing-by-datapoints branch from 5a12ed4 to ad314fe Compare November 25, 2024 18:00
@djaglowski djaglowski marked this pull request as ready for review November 25, 2024 18:17
@djaglowski djaglowski requested a review from a team as a code owner November 25, 2024 18:17
@djaglowski djaglowski closed this Dec 2, 2024
@djaglowski
Copy link
Member Author

Superseded by #36523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants