[receiver/signalfx] follow receiver contract #36376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Nov 16, 2024
dmitryax
reviewed
Nov 16, 2024
|
@open-telemetry/collector-contrib-approvers @dmitryax can this be merged? |
ChrsMark
approved these changes
Nov 20, 2024
ChrsMark
added
the
ready to merge
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
This PR enables awsfirehose to follow [the receiver contract](https://github.com/open-telemetry/opentelemetry-collector/blob/df3c9e38a80ccc3b14705462be2e2e51c628a3b3/receiver/doc.go#L10) and maintain the correct order of operations. The status code returned by the receiver should be dependent upon type of error (i.e. permanent/non-permanent error). Also, updates the helpers to improve readability. --------- Co-authored-by: Dmitrii Anoshin <[email protected]>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
This PR enables awsfirehose to follow [the receiver contract](https://github.com/open-telemetry/opentelemetry-collector/blob/df3c9e38a80ccc3b14705462be2e2e51c628a3b3/receiver/doc.go#L10) and maintain the correct order of operations. The status code returned by the receiver should be dependent upon type of error (i.e. permanent/non-permanent error). Also, updates the helpers to improve readability. --------- Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables awsfirehose to follow the receiver contract and maintain the correct order of operations. The status code returned by the receiver should be dependent upon type of error (i.e. permanent/non-permanent error).
Also, updates the helpers to improve readability.