-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[receiver/elasticsearch] Enable more index metrics by default (#34397)
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This enables the following metrics by default: ``` elasticsearch.index.documents elasticsearch.index.operations.merge.current elasticsearch.index.segments.count ``` **Link to tracking Issue:** <Issue number if applicable> Resolves #34396 **Testing:** <Describe what testing was performed and which tests were added.> Tests have been updated to account for these metrics being enabled by default. One thing to note, some tests were manually enabling these metrics. This is no longer necessary, but I've left as-is since it doesn't do any harm, and can be helpful to ensure tests act the way we want. I can update though if reviewers prefer. Testing side note: For some reason, when running integration tests locally, I had to add a `time.Sleep` call before scraping when the docker container was being spun up. Some metrics and resource attributes weren't populated fully without the delay, and caused a mismatch with the GitHub CI's results that are generated without the sleep call.
- Loading branch information
Showing
9 changed files
with
5,152 additions
and
4,710 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: breaking | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: elasticsearchreceiver | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Enable more index metrics by default | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [34396] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | | ||
This enables the following metrics by default: | ||
`elasticsearch.index.documents` | ||
`elasticsearch.index.operations.merge.current` | ||
`elasticsearch.index.segments.count` | ||
To preserve previous behavior, update your Elasticsearch receiver configuration to disable these metrics. | ||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
receiver/elasticsearchreceiver/internal/metadata/generated_config.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
receiver/elasticsearchreceiver/internal/metadata/generated_metrics_test.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.