Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding disk buffering, part 3 #194

Merged
merged 16 commits into from
Jan 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding ExportScheduleHandler.disable a default impl
LikeTheSalad committed Dec 22, 2023
commit 7c3fe192c231602ace6a06feedf05322760c479a
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ android {
jvmTarget = javaVersion.toString()
apiVersion = minKotlinVersion.version
languageVersion = minKotlinVersion.version
freeCompilerArgs = listOf("-Xjvm-default=all")
}
}

Original file line number Diff line number Diff line change
@@ -18,8 +18,4 @@ class DefaultExportScheduleHandler : ExportScheduleHandler {
.enqueue(DefaultExportScheduler())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the DefaultExportScheduler an instance field passed thru constructor? Both good DI practice and saves object creation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that sounds way better! I'll add the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's updated now.

}
}

override fun disable() {
// No operation.
}
}
Original file line number Diff line number Diff line change
@@ -19,5 +19,5 @@ interface ExportScheduleHandler {
* for data stored in the disk to export will be carried over if this function is called.
* This will be called if the disk buffering feature gets disabled.
*/
fun disable()
fun disable() {}
}