-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding disk buffering, part 3 #194
Merged
LikeTheSalad
merged 16 commits into
open-telemetry:main
from
LikeTheSalad:disk-buffering-part-3
Jan 12, 2024
+604
−7
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
213d35a
Created PeriodicWorkService
LikeTheSalad 452ed06
Adding tests
LikeTheSalad 857c569
Changing loop delays
LikeTheSalad 5ca88c7
Enhancing tests
LikeTheSalad 31bc4bf
Created PeriodicRunnable and time tool
LikeTheSalad 3b3cc1f
Updating javadoc
LikeTheSalad 9d1f570
Adding javadoc
LikeTheSalad d1eb99c
Updating javadoc
LikeTheSalad 8474016
Moving Disk buffering config to its feature dir
LikeTheSalad 663eb9c
Created the DiskExportScheduleHandler
LikeTheSalad 31d1cc0
Renaming DiskExportScheduleHandler
LikeTheSalad 79842cc
Using Mockk and created default export scheduler
LikeTheSalad 804d8bd
Using ConcurrentLinkedQueue for periodic work service
LikeTheSalad 7c3fe19
Adding ExportScheduleHandler.disable a default impl
LikeTheSalad c407bab
Moved DefaultSystemTime to SystemTime.kt
LikeTheSalad 2abf0af
Moving DefaultExportScheduler instance to DefaultExportScheduleHandle…
LikeTheSalad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Adding ExportScheduleHandler.disable a default impl
commit 7c3fe192c231602ace6a06feedf05322760c479a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the
DefaultExportScheduler
an instance field passed thru constructor? Both good DI practice and saves object creation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that sounds way better! I'll add the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's updated now.