-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding disk buffering, part 2 #160
Adding disk buffering, part 2 #160
Conversation
...java/io/opentelemetry/android/internal/features/persistence/SimpleTemporaryFileProvider.java
Show resolved
Hide resolved
...java/io/opentelemetry/android/internal/features/persistence/SimpleTemporaryFileProvider.java
Outdated
Show resolved
Hide resolved
instrumentation/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.java
Outdated
Show resolved
Hide resolved
instrumentation/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.java
Show resolved
Hide resolved
instrumentation/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.java
Outdated
Show resolved
Hide resolved
instrumentation/src/test/java/io/opentelemetry/android/OpenTelemetryRumBuilderTest.java
Outdated
Show resolved
Hide resolved
instrumentation/src/main/java/io/opentelemetry/android/OpenTelemetryRumBuilder.java
Outdated
Show resolved
Hide resolved
instrumentation/src/main/java/io/opentelemetry/android/OpenTelemetryRumBuilder.java
Outdated
Show resolved
Hide resolved
instrumentation/src/main/java/io/opentelemetry/android/OpenTelemetryRumBuilder.java
Outdated
Show resolved
Hide resolved
@breedx-splk I think I've addressed all your comments, please let me know if there's something else pending! |
.../io/opentelemetry/android/internal/features/persistence/SimpleTemporaryFileProviderTest.java
Show resolved
Hide resolved
...java/io/opentelemetry/android/internal/features/persistence/SimpleTemporaryFileProvider.java
Outdated
Show resolved
Hide resolved
|
||
private static SpanExporter createDiskExporter( | ||
SpanExporter defaultExporter, DiskBufferingConfiguration diskBufferingConfiguration) | ||
throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only IOEx or also securityexception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment it's only IOExceptions thrown in case the dirs cannot be created for whatever reason.
Related to #132
This part connects the tools added in the previous part to the OpenTelemetryRumBuilder class.
For the next part, "Fun with Threads":