Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding disk buffering, part 2 #160

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

LikeTheSalad
Copy link
Contributor

Related to #132

This part connects the tools added in the previous part to the OpenTelemetryRumBuilder class.

For the next part, "Fun with Threads":

@LikeTheSalad LikeTheSalad requested a review from a team November 25, 2023 07:50
@LikeTheSalad LikeTheSalad changed the title Using disk span exporter Using disk span exporter, part 2 Nov 25, 2023
@LikeTheSalad LikeTheSalad changed the title Using disk span exporter, part 2 Adding disk buffering, part 2 Nov 25, 2023
@LikeTheSalad
Copy link
Contributor Author

@breedx-splk I think I've addressed all your comments, please let me know if there's something else pending!


private static SpanExporter createDiskExporter(
SpanExporter defaultExporter, DiskBufferingConfiguration diskBufferingConfiguration)
throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only IOEx or also securityexception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it's only IOExceptions thrown in case the dirs cannot be created for whatever reason.

@LikeTheSalad LikeTheSalad merged commit cfe22e6 into open-telemetry:main Dec 12, 2023
1 check passed
@LikeTheSalad LikeTheSalad deleted the disk-buffering-part-2 branch December 12, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants