Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making android min sdk configurable per auto-instrumentation subproject #147

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Making android min sdk configurable per auto-instrumentation subproject #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion buildSrc/src/main/kotlin/otel.java-library-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ plugins {
id("ru.vyarus.animalsniffer")
}

// Extension to configure android parameters for non-android projects.
interface OtelAndroidExtension {
val minSdk: Property<Int>
}

val otelAndroidExtension =
project.extensions.create("otelAndroid", OtelAndroidExtension::class.java)
otelAndroidExtension.minSdk.convention((project.property("android.minSdk") as String).toInt())

java {
val javaVersion = rootProject.extra["java_version"] as JavaVersion
sourceCompatibility = javaVersion
Expand All @@ -14,7 +23,6 @@ java {

val libs = extensions.getByType<VersionCatalogsExtension>().named("libs")
dependencies {
signature("com.toasttab.android:gummy-bears-api-${project.property("android.minSdk")}:0.5.1:coreLib@signature")
implementation(libs.findLibrary("findbugs-jsr305").get())
}

Expand All @@ -31,3 +39,9 @@ tasks.withType<AnimalSniffer> {
tasks.named("classes").configure {
finalizedBy("animalsnifferMain")
}

afterEvaluate {
dependencies {
signature("com.toasttab.android:gummy-bears-api-${otelAndroidExtension.minSdk.get()}:0.5.1:coreLib@signature")
}
}