-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Go Compile Time Instrumentation SIG #2490
base: main
Are you sure you want to change the base?
Conversation
b5906f5
to
2f8081e
Compare
Co-authored-by: Pablo Baeyens <[email protected]>
I approve! |
1 similar comment
I approve! |
@123liuziming @NameHaibinZhang @y1yang0 can you please review the changes and approve it if it looks good to you (instead of only leaving a comment)? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I do not realize that I have the access to approve, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comment/suggestion isn't blocking, I'm happy to sponsor this SIG!
Should this project proposal include mentions of the two donation proposals that will be considered as part of this work? The one from Alibaba in #2344 and Datadog in #2497 I think it's awesome that we can get the best learnings from each and provide the community with a unified approach. Would love to see it reflected here. |
How about adding the following content to the end of the proposal ReferenceThe project is a joint effort of donation proposal coming from Alibaba and Datadog. The proposals are listed as follows: |
I think that'd be great @ralf0131 |
All the suggestion are applied. |
I think, we could also mention that goal is also to replace https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrgen |
Sure. How about this? The project is a joint effort of donation proposal coming from Alibaba and Datadog to replace Instrgen. The proposals are listed as follows: |
fixed in #2503 and merged latest into your branch, should be fixed now |
This is a proposal to establish the Go compile time instrumentation SIG. The background has been discussed in #1961. A consensus has been reached among GC/TC members, Go maintainers and multiple interested vendors.
We believe that the Go Compile Time Instrumentation SIG ensures that Go applications benefit from standardized, vendor-neutral, high-quality observability solutions that are both robust and easy to implement. Having one single, standard tool removes decision points from prospective developers, which makes the path to observability shorter & easier.