fix #47

docs/changelog.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+## [1.11.1.4]
+
+-   fix #47 null error;
+-   fix occasionally can't open flashcard modal;
+-   fix lint errors;
+
 ## [1.11.1.3]
 
 -   merge master branch;

manifest.json

@@ -1,7 +1,7 @@
 {
     "id": "obsidian-spaced-repetition-recall",
     "name": "Spaced Repetition Recall",
-    "version": "1.11.1.3",
+    "version": "1.11.1.4",
     "minAppVersion": "0.15.4",
     "description": "Fight the forgetting curve by reviewing flashcards & entire notes.",
     "author": "Newdea",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "obsidian-spaced-repetition",
-    "version": "1.11.1.3",
+    "version": "1.11.1.4",
     "description": "Fight the forgetting curve by reviewing flashcards & entire notes.",
     "main": "main.js",
     "scripts": {

src/algorithms/balance/reschedule.ts

@@ -1,11 +1,11 @@
 import { RepetitionItem } from "src/dataStore/repetitionItem";
 import { DateUtils, debug } from "src/util/utils_recall";
 import { SrsAlgorithm } from "../algorithms";
 import { FsrsAlgorithm, FsrsData } from "../fsrs";
 
 export function reschedule(items: RepetitionItem[]): RepetitionItem[] {
     let reCnt = 0;
-    console.group(`reschedule`);
+    console.group("reschedule");
     if (items[0].isFsrs) {
         const result = reschedule_fsrs(items);
         reCnt = result.reCnt;

src/algorithms/supermemo.ts

@@ -2,7 +2,6 @@ import { DateUtils, MiscUtils } from "src/util/utils_recall";
 import { SrsAlgorithm, algorithmNames } from "./algorithms";
 import deepcopy from "deepcopy";
 import { AnkiAlgorithm, AnkiSettings } from "./anki";
-import { balance } from "./balance/balance";
 import { RepetitionItem, ReviewResult } from "src/dataStore/repetitionItem";
 
 interface Sm2Data {
@@ -78,7 +77,7 @@ export class Sm2Algorithm extends SrsAlgorithm {
                 nextReview: nextReview * DateUtils.DAYS_TO_MILLIS,
             };
         } else {
-            let nextReview = interval(data.iteration);
+            const nextReview = interval(data.iteration);
             data.iteration += 1;
             data.ease = data.ease + (0.1 - (5 - q) * (0.08 + (5 - q) * 0.02));
             if (data.ease < 1.3) {

src/dataStore/itemToDecks.ts

@@ -118,15 +118,15 @@ export class ItemToDecks {
         let now_number: number = now;
         const nowToday: number = DateUtils.EndofToday;
 
-        if (!trackedFile.isDefault && (item == null || !item.isTracked)) {
-            item.setTracked(ind);
-        }
         if (item == null) {
             // store._updateItem(fileid, ind, RPITEMTYPE.NOTE, rdeck.deckName);
             // item = store.getItembyID(fileid);
             console.debug("syncRCDataToSRrevDeck update null item:", item, trackedFile);
             return;
         }
+        if (!trackedFile.isDefault && !item.isTracked) {
+            item.setTracked(ind);
+        }
         const latterQue = store.data.queues.toDayLatterQueue;
         delete latterQue[fileid];
         if (now == null) {

src/main.ts

@@ -892,7 +892,7 @@ export default class SRPlugin extends Plugin {
         await this.saveData(this.data);
     }
 
-    initView(): void {
+    async initView(): Promise<void> {
         this.registerView(
             REVIEW_QUEUE_VIEW_TYPE,
             (leaf) => (this.reviewQueueView = new ReviewQueueListView(leaf, this)),
@@ -902,10 +902,11 @@ export default class SRPlugin extends Plugin {
             this.data.settings.enableNoteReviewPaneOnStartup &&
             this.app.workspace.getLeavesOfType(REVIEW_QUEUE_VIEW_TYPE).length == 0
         ) {
-            this.app.workspace.getRightLeaf(false).setViewState({
+            await this.app.workspace.getRightLeaf(false).setViewState({
                 type: REVIEW_QUEUE_VIEW_TYPE,
                 active: true,
             });
+            this.reviewQueueView = this.app.workspace.getActiveViewOfType(ReviewQueueListView);
         }
     }