generated from open-source-uc/osuc-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minors y titulos faltantes #366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fagiannoni
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 todo excelente! Tremendo PR 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limpie el codigo del scraper de minors y titulos, y lo movi al planner mismo. Antes el flujo de datos era algo:
Ahora es mas como:
Hay dos razones por la que el mock de SIDING sigue siendo offline (en lugar de descargar los planes desde SIDING al momento de correr planner):
Para los planes más complejos, agregue una fuente adicional de planes curriculares, que es simplemente hardcodear los planes en un formato más flexible.
¿Qué se implementa?
Cyear
sea directamente una union de literales en lugar de una clase dedicada, y los cambios asociados en el frontend.¿Qué falta?
Solo faltan 5 majors, que SIDING no entrega correctamente:
SIDING tiene que agregar estos majors.