Upgrade to Conan 2

[kyllingstad]

Building on @eidekrist's earlier work, here I've completed the transition to Conan 2. The main changes are:

• Updated conanfile.py to the new format.
• Updated conan invocations in the GH Actions workflow to use the new command-line options.
• Switched to using version ranges for dependencies, for greater flexibility.
• Removed most of the custom find_package scripts, relying instead on package configuration files provided by Conan (in Conan builds) or by upstream (in non-Conan builds).
• Removed the ability to run Conan from within CMake.

Regarding the last point: I really tried to make this work, but the upstream cmake-conan project has not released a version with full support for all features yet. Notably, their current development version does not support the CMakeToolchain generator. I also tried to modify the Build workflow to use Conan 1.61, but unfortunately, that version does not have sufficient support for Conan 2.0 features. I suggest we reintroduce this as soon as upstream releases a more feature complete cmake-conan version.

[markaren]

Removed the ability to run Conan from within CMake.

Removing this feature also for the future is totally legit and also a requirement at this stage

[davidhjp01]

Are we skipping test step by removing build.yml?

[kyllingstad]

Oops, you're right. I've restored the deleted workflow and cleaned it up a bit.

[davidhjp01]

Since the build process for conan2 has been changed, it would be good to have an updated README.md that explains how to build the source locally for development and release purposes.

[kyllingstad]

The current README simply refers users to the CI workflow setup for instructions. This is good in the sense that the instructions will always be up-to-date and known to work, but it is unfortunate in the sense that it requires users to have at least some understanding of the GitHub workflow definition files.

Do I understand you correctly that you wish me to add the instructions to the README? (If not, I still have to update the link to the workflow file, since I changed its name.)

[kyllingstad]

The "Build and test" workflow fails in the "Build" step for reasons I do not understand and don't really know how to debug, because the exact same commands work perfectly on my computer. It's complaining that <thrift/Thrift.h> cannot be found, even though the find_package(Thrift) command apparently succeeds in the "Generate build system" step. (And it also builds just fine when the whole process is driven by Conan in the "Upload Conan packages" workflow.)

@markaren, @davidhjp01, all ideas are welcome. And it would be great if you too could test the same commands locally if you have the chance.

[davidhjp01]

The build and test workflow now succeeds.

There are still issues remain (need discussion):

1. conan2 does not copy output files to bin directory during build. This causes ctest to fail (see the comments). We need to either set CMAKE_RUNTIME_OUTPUT_DIRECTORY_XXX or install files to build/bin directory.
2. Some of the conan2 libraries uploaded conan.io does not have Debug builds that triggers rebuilding of large libraries like boost, openssl. This increases the overall build time quite drastically (~30mins). Need to upload the build library to jfrog or cache them during build.

[davidhjp01]

Using preset for cmake configure and build

[davidhjp01]

using cmake preset to configure and build (notice conan-default in case for Windows when configuring).

[davidhjp01]

outputs are not copied to bin directory. This is because we do not call conan_output_dirs_setup in conan2.

We need to either copy the following (from conanv1) to our cmake or --target install all the artifacts to bin before upload. I have not fixed this issue yet.

macro(conan_output_dirs_setup)
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/bin)
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_MINSIZEREL ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})

    set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib)
    set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELEASE ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})
    set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_RELWITHDEBINFO ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})
    set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_MINSIZEREL ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})
    set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG ${CMAKE_ARCHIVE_OUTPUT_DIRECTORY})

    set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib)
    set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
    set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELWITHDEBINFO ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
    set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_MINSIZEREL ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
    set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
endmacro()

[davidhjp01]

Ctest failed because conan2 did not copy output files to bin (On windows, .exe can load .dlls in the same dir).