Address exception classes for user vs. program errors #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #782 by changing to
std::runtime_error
where the cause is incorrect configuration in the XMLs.While that squashes one loose chicken, a cursory glance at the codebase reveals several other places that could use similar changes. For instance,
std::invalid_argument
exceptions still abound inscenario_parser.cpp
. And there probably are other places wherestd::out_of_range
orstd::logic_error
may be dubiously applied.