Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hard coded height #262

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: remove hard coded height #262

merged 2 commits into from
May 1, 2024

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented May 1, 2024

Description

I removed the forced height on the border. Kind weird decision made there, but I guess something to learn from.

Related Tickets & Documents

#261

Mobile & Desktop Screenshots/Recordings

before
Screenshot 2024-05-01 at 7 04 29 AM

after

Screenshot 2024-05-01 at 7 22 29 AM

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@bdougie bdougie requested a review from a team May 1, 2024 14:23
Copy link

netlify bot commented May 1, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 386814c
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6632c7e3f4b1a5000906f96e
😎 Deploy Preview https://deploy-preview-262--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie bdougie changed the title remove hard coded height fix: remove hard coded height May 1, 2024
Copy link
Member

@BekahHW BekahHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better. I thought that was a "Creative choice."

@nickytonline nickytonline merged commit 7e1b52f into main May 1, 2024
6 checks passed
@nickytonline nickytonline deleted the fix-square-images branch May 1, 2024 23:51
@bdougie bdougie mentioned this pull request May 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants