fix: syntax error being thrown in Firefox for anonymous objects with computed property names

[nickytonline]

Description

The extension does not currently work in Firefox. This PR does not fix that, but addresses one of the errors that occurs when trying to get the extension to work in Firefox.

Firefox supports objects with computed property names, which allows using a variable as the key, for instance:

{ [OPEN_SAUCED_OPTED_LOG_OUT_KEY]: false }

In Firefox, this syntax requires it to be assigned to a variable, otherwise, it throws an error.

The fix involves assigning the object with the computed property name to a variable, like this:

Then it can be used in the code, like this:

const optedLogout = { [OPEN_SAUCED_OPTED_LOG_OUT_KEY]: false };

void chrome.storage.local.set(optedLogout);

To test this fix, ensure that things still behave correctly when the browser extension is running in a Chromium based browser (Chrome, Microsoft Edge, Arc Browser etc.)

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

Relates to #237

Mobile & Desktop Screenshots/Recordings

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📜 README.md
• 📓 docs.opensauced.pizza
• 🍕 dev.to/opensauced
• 📕 storybook
• 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

[github-actions]

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

[Anush008]

Thank you this contribution.

[bdougie]

I submitted these updates to firefox. I am still working through how to test this and uploading a local version as well.

[nickytonline]

I submitted these updates to firefox. I am still working through how to test this and uploading a local version as well.

There's not much to test in regards to Firefox. The login will still fail (no nothing). This is just one of a few errors I've encountered so far. You won't be able to test it locally at the moment in Firefox as there is a branch I have to get Firefox working which includes manifest file changes.

The best bet is to just ensure it still works fine in Chromium based browsers, i.e. the login

[jpmcb]

there is a branch I have to get Firefox working which includes manifest file changes.

I'm assuming these are manifest changes for things like background which firefox doesn't seem to support the type property. When I've tried to load the extension's manifest locally, I get:

There was an error during the temporary add-on installation.
Error details

Extension is invalid

Reading manifest: Error processing background: Value must either: contain the required "page" property, contain the required "scripts" property, or not contain an unexpected "type" property

which seems that firefox doesn't support the service worker background: https://stackoverflow.com/questions/73440104/failing-to-export-to-background-js-from-a-common-script-under-firefox-with-mv3

---

Regardless, this looks good to me!!

[nickytonline]

there is a branch I have to get Firefox working which includes manifest file changes.

I'm assuming these are manifest changes for things like background which firefox doesn't seem to support the type property. When I've tried to load the extension's manifest locally, I get:

There was an error during the temporary add-on installation.
Error details

Extension is invalid

Reading manifest: Error processing background: Value must either: contain the required "page" property, contain the required "scripts" property, or not contain an unexpected "type" property

which seems that firefox doesn't support the service worker background: stackoverflow.com/questions/73440104/failing-to-export-to-background-js-from-a-common-script-under-firefox-with-mv3

Regardless, this looks good to me!!

Yeah, like I said, this is one small fix. I'll have my Firefox branch for a while as there's other stuff I need to sort out still, and the manifest I have will need to be copied pre-build for Firefox etc. when it comes to the automated deployment.

[jpmcb]

Ah, I see you mentioned that in the original issue: #237 (comment) 😅 this looks great! Thanks for all the legwork on this so far!

[bdougie]

I plan on streaming tomorrow and can take a closer look at this then. At the very least I am learning a lot more about Firefox.

[nickytonline]

I plan on streaming tomorrow and can take a closer look at this then. At the very least I am learning a lot more about Firefox.

I'll push my branch later tonight where I'm experimenting if you want to take a peek at that. I'll tag it in #237

[nickytonline]

I plan on streaming tomorrow and can take a closer look at this then. At the very least I am learning a lot more about Firefox.

I'll push my branch later tonight where I'm experimenting if you want to take a peek at that. I'll tag it in #237

#237 (comment)

[github-actions]

🎉 This PR is included in version 1.14.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀