Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate customizations from rust-1.68.0 to rust-1.74.0 #31

Merged
merged 53 commits into from
Dec 1, 2023
Merged

Migrate customizations from rust-1.68.0 to rust-1.74.0 #31

merged 53 commits into from
Dec 1, 2023

Conversation

J-ZhengLi
Copy link

changelog: none

surechen and others added 30 commits December 1, 2023 14:40
@surechen @J-ZhengLi
add lint extern_without_repr
440e169 
Signed-off-by: surechen <[email protected]>
@J-ZhengLi
add guidelines type and barebone for [mem_unsafe_functions] lint
4ffb91c 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
init following new lints:
8a27eb4 
[`passing_string_to_c_functions`]
[`untrusted_lib_loading`]
[`falliable_memory_allocation`]

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add configuration for lint [mem_unsafe_functions];
4f9a861 
finish implement lint [`mem_unsafe_functions`];
add simple description for unimplemented lints;

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add new lint [unsafe_block_in_proc_macro]
e88c503 
that detects unsafe block in `quote!`

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add new lint [implicit_abi]
5b97c20 
that detects external block without explicit label "C"

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix test fail after dev fmt of [implicit_abi]
acd0a7b 
Signed-off-by: J-ZhengLi <[email protected]>
@kiscad @J-ZhengLi
new_lint non_reentrant_functions
4bcbf5c 
Signed-off-by: mojave2 <[email protected]>
@kiscad @J-ZhengLi
doc-comment non_reentrant_functions
65ce330 
Signed-off-by: mojave2 <[email protected]>
@kiscad @J-ZhengLi
improve implementation by dogfood
91a35ad 
Signed-off-by: mojave2 <[email protected]>
@kiscad @J-ZhengLi
update_lint non_reentrant_functions
a07f5d4 
Signed-off-by: mojave2 <[email protected]>
@kiscad @J-ZhengLi
update_lint non_reentrant_functions
5b8547b 
Signed-off-by: mojave2 <[email protected]>
@kiscad @J-ZhengLi
new_line loop_without_break_or_return
4bfc2ec 
Signed-off-by: mojave2 <[email protected]>
@SparrowLii @J-ZhengLi
implement 3 lints
2717b0c 
Signed-off-by: SparrowLii <[email protected]>
@SparrowLii @J-ZhengLi
improve error messages
544488e 
Signed-off-by: SparrowLii <[email protected]>
@SparrowLii @J-ZhengLi
add IO functions list
09648af 
Signed-off-by: SparrowLii <[email protected]>
@J-ZhengLi
add new configurable lint [blocking_op_in_async]
5d42153 
that detects function calls that blocks thread under async context.

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fmt & dogfood tests after rebasing
4013261 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
move [unsafe_block_in_proc_macro] lint under guidelines
732996a 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix [blocking_op_in_async] FN on some test cases
1c562a5 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
enhance lint [fallible_memory_allocation] by:
89ea43e 
fix name typo;
add configuration;
add tests;
add more precised checks;
limit check ranges to external functions, and `Vec::with_capacity` only;
some other nit changes;

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
refractoring for [passing_string_to_c_functions];
d227c39 
add some additional test cases;

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
update ui test cases to fix cross platform tests
113d0f6 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
organizing guideline lints to make them a bit more portable
b050359 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
make [untrusted_lib_loading] more precise by:
ba74d3d 
- add configurations to allow additional detected functions
- only checks for functions `DefId` instead of its name ident
- check for io function call with matching args rather than any io calls.
- change error output
- code refractoring

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
improve lint [extern_without_repr] by:
fbef5bb 
- add more test cases
- disallow `repr(simd)` for extern mod funtion items
- improve error messages and include type usage span
- code refractoring

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
change [non_reentrant_functions] pass to LateLintPass
e265ddc 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
update [non_reentrant_functions] ui test cases.
4c046c8 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
enhance [non_reentrant_functions] logic and add configuration support
34faa08 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
change output format for lint [loop_without_break_or_return]
8cc3352 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
slightly optimize check_expr calls for guideline lints
0acb0db 
adjust `guidelines` lints configuration so that all configured function list will override existing ones;
move all configurable `guidelines` ui-toml tests into a single folder;

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add ui-toml test for [fallible_memory_allocation] & fix;
8f2b5a0 
one false negative problem left to fix

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix FP for lint [extern_without_repr]
5c301cf 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix FP for lint [fallible_memory_allocation]
141841a 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix [loop_without_break_or_return] on macro call
005822a 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
hopefully fixing [unsafe_block_in_proc_macro] FP, with the lack of …
7336d70 
…ui test

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
[loop_without_break_or_return]: fix FP with let patterns
079f39d 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
revive unit test for [unsafe_block_in_proc_macro]
9398b00 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
rename [loop_without_break_or_return] to [infinite_loop]
ffa4dec 
and rewite using visitors for more in-depth detection

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
cleanup useless design residuals
4aa03c4 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix bug where unlabeled nested loops are not properly checked
3d2bf23 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
refactoring [blocking_op_in_async] with visitors
ebd6801 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
adjust code for rust 1.68.0
ca67d2f 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix FN where libc functions are failed to be detected
ccc9106 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
new lint [null_ptr_dereference]
f96e456 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add logic and test cases for [null_ptr_dereference]
1ce5097 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
barebone for new lint [unsound_memory_deallocation]
9217ee4 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
split the last added lint into [ptr_double_free] and [`dangling_ptr…
c4ae568 
…_dereference`];

Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
new lint [return_stack_address]
14b68eb 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
fix FP and ICE error
7e298d5 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi
add [infinite_loop] as rename lints
c3f27ce 
Signed-off-by: J-ZhengLi <[email protected]>
@J-ZhengLi J-ZhengLi force-pushed the custom_lints_1.74.0 branch 6 times, most recently from f2f1b3c to f25fa70 Compare December 1, 2023 09:49
@surechen
Copy link

surechen commented Dec 1, 2023

LGTM

@surechen surechen merged commit d5b213b into open-rust-initiative:custom-lint-1.74.0 Dec 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@J-ZhengLi @surechen @kiscad @SparrowLii