Skip to content

Commit

Permalink
Bump microsoft/setup-msbuild from 1.3.1 to 2.0.0 (onnx#5892)
Browse files Browse the repository at this point in the history
Bumps
[microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild)
from 1.3.1 to 2.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/microsoft/setup-msbuild/releases">microsoft/setup-msbuild's
releases</a>.</em></p>
<blockquote>
<h2>v2</h2>
<p>This is a major version bump with no functionality changes. The major
version change is due to moving to <code>node20</code> for the node
version per the deprecation announcement for GitHub Actions (<a
href="https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/">https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/</a>).
This change from <code>node16</code> to <code>node20</code> could cause
breaking changes to other workflow actions steps (see <a
href="https://redirect.github.com/microsoft/setup-msbuild/issues/125">#125</a>)
running and needing/leveraging expected functionality in
<code>node16</code> and thus as a safe boundary, changing the version
here.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/microsoft/setup-msbuild/compare/v1.3...v2">https://github.com/microsoft/setup-msbuild/compare/v1.3...v2</a></p>
<h2>v1.3.3</h2>
<p>This is a patch update that reverts the node16-&gt;node20 change
which introduced unintended breaking changes for users of this action.
The v1, v1.3 tags have been updated to this release as well.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/microsoft/setup-msbuild/compare/v1.3.2...v1.3.3">https://github.com/microsoft/setup-msbuild/compare/v1.3.2...v1.3.3</a></p>
<h2>v1.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update test.yml by <a
href="https://github.com/mosfet80"><code>@​mosfet80</code></a> in <a
href="https://redirect.github.com/microsoft/setup-msbuild/pull/122">microsoft/setup-msbuild#122</a></li>
<li>Update to node20 by <a
href="https://github.com/kawon7317"><code>@​kawon7317</code></a> in <a
href="https://redirect.github.com/microsoft/setup-msbuild/pull/124">microsoft/setup-msbuild#124</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mosfet80"><code>@​mosfet80</code></a>
made their first contribution in <a
href="https://redirect.github.com/microsoft/setup-msbuild/pull/122">microsoft/setup-msbuild#122</a></li>
<li><a href="https://github.com/kawon7317"><code>@​kawon7317</code></a>
made their first contribution in <a
href="https://redirect.github.com/microsoft/setup-msbuild/pull/124">microsoft/setup-msbuild#124</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/microsoft/setup-msbuild/compare/v1.3.1...v1.3.2">https://github.com/microsoft/setup-msbuild/compare/v1.3.1...v1.3.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce"><code>6fb0222</code></a>
Address issue <a
href="https://redirect.github.com/microsoft/setup-msbuild/issues/125">#125</a>
releasing the node20 action as major version change</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/ede762b26a2de8d110bb5a3db4d7e0e080c0e917"><code>ede762b</code></a>
Reverting to node16 for compat in 1.x versions</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/031090342aeefe171e49f3820f3b52110c66e402"><code>0310903</code></a>
Updated lock</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/79fdc4b9cf2de940ec8edb27d18a1f43b81fec52"><code>79fdc4b</code></a>
Version bump</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/56275591f5cb6bb1055e88e0feb8b004f22d9785"><code>5627559</code></a>
Merge branch 'kawon7317-main'</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/faa06544ad91b491516e8f4b63811db481e8937c"><code>faa0654</code></a>
Update action.yml</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/c9685f2ae51d7aef1293aa76a1c747ef8dde8c43"><code>c9685f2</code></a>
Merge pull request <a
href="https://redirect.github.com/microsoft/setup-msbuild/issues/122">#122</a>
from mosfet80/patch-1 [skip ci]</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/f37d07ecbdf427acae8670d1343c7e7008b4d15d"><code>f37d07e</code></a>
Update test.yml</li>
<li><a
href="https://github.com/microsoft/setup-msbuild/commit/3404ff3d40458f8d1fdf55c2bcc442b970404ad7"><code>3404ff3</code></a>
Adding runner image doc note [skip ci]</li>
<li>See full diff in <a
href="https://github.com/microsoft/setup-msbuild/compare/1ff57057b5cfdc39105cd07a01d78e9b0ea0c14c...6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=microsoft/setup-msbuild&package-manager=github_actions&previous-version=1.3.1&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Chu <[email protected]>
  • Loading branch information
dependabot[bot] and justinchuby authored Feb 2, 2024
1 parent 3cd21a9 commit 570f41b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release_win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
architecture: ${{ matrix.architecture }}

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@1ff57057b5cfdc39105cd07a01d78e9b0ea0c14c # v1.3.1
uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2.0.0
with:
msbuild-architecture: ${{ matrix.architecture }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/win_no_exception_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
architecture: ${{ matrix.architecture }}

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@1ff57057b5cfdc39105cd07a01d78e9b0ea0c14c # v1.3.1
uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2.0.0
with:
msbuild-architecture: ${{ matrix.architecture }}

Expand Down

0 comments on commit 570f41b

Please sign in to comment.