Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics graph generation helpers #31

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add statistics graph generation helpers #31

merged 3 commits into from
Nov 6, 2023

Conversation

Bluesy1
Copy link
Collaborator

@Bluesy1 Bluesy1 commented Nov 1, 2023

Currently only adds a function for shaded normal density curves, but I'm willing to create more for other distributions/common plots

This does add a dependency on Matplotlib and SciPy, but both of those are already available on PrairieLearn

I've created a Jupyter Notebook to demo the function since I'm unsure how I can add tests for this function since it outputs just figures.

@Bluesy1 Bluesy1 requested a review from firasm November 1, 2023 01:59
@Bluesy1 Bluesy1 self-assigned this Nov 1, 2023
@firasm
Copy link
Contributor

firasm commented Nov 3, 2023

I didn't look at the code too deeply (matplotlib code is just...) but I did look at the Jupyter notebook and the outputs.

This looks good to me! Let me just get feedback from others working on the stats bank, and then we can merge.

@firasm firasm merged commit ae2286a into main Nov 6, 2023
1 check passed
@Bluesy1 Bluesy1 deleted the add-stats-helpers branch November 7, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants