Update base64 function names #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the names of these two functions to make them simpler to use (and so the type isn't part of the function name) I'll do a find and replace in instructor_datascience_bank to fix this on any questions that are currently using this.
Bluesy1
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Seems reasonable to me, and looks correct - I'll have to update open-resources/instructor_datascience_bank#232 once this is merged and released so I'll hold off requesting any reviews on that until then.
Should probably make some tests for these functions at somepoint to actually make sure they stay working, but thats out of scope for this PR
Bluesy1
reviewed
Aug 17, 2023
Bluesy1
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the names of these two functions to make them simpler to use/remember (and so the type isn't part of the function name)
I'll do a find and replace in instructor_datascience_bank to fix this on any questions that are currently using this.