Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CI for apple mobile platforms #1546

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

res0nance
Copy link
Contributor

Adds CI for Apple mobile platforms.

Unfortunately I'm not sure how to effectively run the tests within the emulator. Plus it will likely be incredibly flaky. I think we should compile test this until we can figure out how to better run the full suite of tests.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Brings build-testing to the same level as for android (#1531). Thanks for the contribution!

@res0nance res0nance mentioned this pull request Sep 13, 2023
2 tasks
@dstebila dstebila merged commit cc313b2 into open-quantum-safe:main Sep 13, 2023
17 checks passed
@res0nance res0nance deleted the apple-ci branch September 13, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants