Add support for ML-DSA context #29
Conversation
johngray-dev
commented
Dec 10, 2024
johngray-dev
commented
- Added support for the ML-DSA Context
- Updated version to 1.1
- Added Tests for testing the context in java.
- Question: If an algorithm that doesn't support a context calls the API with a context, is it expected to fail, or should the context just be ignored by the libOQS library. I think it should fail because it would be operator error, and they should be alerted to the fact that they are trying to call an algorithm with a context that doesn't support a context.
- Add testing for the context
|
When resolved, this closes #27 |
liboqs will return an error code unless the provided context / length are NULL / 0. See https://github.com/open-quantum-safe/liboqs/blob/0.12.0/src/sig/mayo/sig_mayo_1.c#L92 for an example. |
There was a problem hiding this comment.
Thanks for this @johngray-dev! Would you also be able to switch out the tests/examples to use ML-KEM / ML-DSA instead of Kyber / Dilithium? Since this will be a new release, it would be nice for it to work with future versions of liboqs that no longer support the older algorithms.
| @@ -69,4 +104,12 @@ private static Stream<String> getEnabledSigsAsStream() { | |||
| return enabled_sigs.parallelStream(); | |||
| } | |||
|
|
|||
| // /** | |||
There was a problem hiding this comment.
Is there a reason for this commented code block?
There was a problem hiding this comment.
It was added because only ML-DSA can use a context at the moment. I suppose in the future SLH-DSA and others might make use of it, and they would need testing as well.
…st that makes use of the algorithms only makes use algorithms that support the context (ML-DSA at the moment).
Signed-off-by: John Gray <[email protected]>
- Add testing for the context Signed-off-by: John Gray <[email protected]>
Signed-off-by: John Gray <[email protected]>
…st that makes use of the algorithms only makes use algorithms that support the context (ML-DSA at the moment). Signed-off-by: John Gray <[email protected]>
|
Fixing up issues in a different branch. Will submit a new pull. |
