Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/openfreemap #347

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Features/openfreemap #347

wants to merge 4 commits into from

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Oct 18, 2024

Updated the map view to clearly show nodata areas (i.e. Saarland & other countries currently 🙃). Also changed our vector tile source to OpenFreeMap, in order to be ready to add more data layers from across Europe 😉

Considerations:

  • Should we also change the on-click behaviour to disallow manual map picks in areas where we don't have data?
  • Currently the nodata mask fades to transparent when the user zooms in as the mask is quite low-poly to reduce traffic, and therefore looks ugly from up close. Does this make sense?

image

@khdlr khdlr requested review from FlorianK13 and MartGro October 18, 2024 07:46
@FlorianK13
Copy link
Member

FlorianK13 commented Oct 18, 2024

New map looks very nice. I think it would be a good feature that simulation clicks are only possible in the light area.

The fading to transparent is fine for me.

@FlorianK13
Copy link
Member

Building footprints and 3D Building data will not match anymore, right? But as soon as we want to include other countries we need to change maps anyway so I guess it's fine.

@khdlr
Copy link
Member Author

khdlr commented Nov 29, 2024

Another current issue with this: OpenFreeMap is only used for the MapLibre map on the starting page, the 3D view can only display rastered map tiles (which we currently get from basemap.de)

2 possible solutions:

  • Leave this as is for the moment (will break as soon as we integrate non-German data)
  • Find a way to get MapLibre to render to textures directly (does not seem to be documented)

@khdlr
Copy link
Member Author

khdlr commented Nov 29, 2024

@FlorianK13 this should now be ready to merge with the caveat mentioned above (3d view still uses the basemap.de raster map)

@FlorianK13
Copy link
Member

For me this is fine

@khdlr
Copy link
Member Author

khdlr commented Nov 29, 2024

Sneaked in one more quick fix regarding weird rendering of airports in the vector maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants