Skip to content

Commit

Permalink
xive: Fix setting of remote NVT VSD
Browse files Browse the repository at this point in the history
Unlike the other remote VSDs, the NVT one needs a valid size field
that represents the size of the remote PC BAR. Without this, multi
chip machines may checkstop when a processor pool or OS CAM gets
attached to a VP on a different chip.

Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Stewart Smith <[email protected]>
  • Loading branch information
ozbenh authored and stewartsmith committed Apr 5, 2017
1 parent 036d2e8 commit dc70177
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hw/xive.c
Original file line number Diff line number Diff line change
Expand Up @@ -1854,8 +1854,10 @@ static void xive_setup_forward_ports(struct xive *x, struct proc_chip *remote_ch

/* NVT/VPD points to the remote NVT MMIO sets */
if (!xive_set_vsd(x, VST_TSEL_VPDT, remote_id,
base | (uint64_t)remote_xive->pc_base))
base | ((uint64_t)remote_xive->pc_base) |
SETFIELD(VSD_TSIZE, 0ull, ilog2(PC_BAR_SIZE) - 12)))
goto error;

return;

error:
Expand Down

0 comments on commit dc70177

Please sign in to comment.