fix: make sure lookup_ip_addr throwing builtin-err in test #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: boranx <[email protected]>
boranx
force-pushed
the
fix-builtin-test
branch
from
0889afd to
cfec0a4
Compare
|
I'll go ahead and fix the test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like non-existent domains are no longer causing built-in-err for
lookup_ip_addr, except the parse-related issues.This PR makes sure
lookup_ip_addrused in tests throws a parse error which causes builtin-errIt seems there's a regression on our test when the underlying name-resolution libs behavior changed after an opa/golang version update: https://github.com/open-policy-agent/opa/blob/main/docs/content/policy-reference.md#notes-on-name-resolution-netlookup_ip_addr
Addresses CI errors on: #1016 #1015 #1009 #1008