Fix: Use correct default for RotationCheckFrequency (12h instead of 90d) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-kuro
force-pushed
the
d-kuro/fix-default-rotation-check
branch
from
5a2f6b7 to
d8f5f7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 57.16% 57.49% +0.32%
==========================================
Files 1 1
Lines 572 574 +2
==========================================
+ Hits 327 330 +3
+ Misses 181 180 -1
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ue as the LookaheadInterval (90 days), which is not its intended behavior. This commit changes the default RotationCheckFrequency to 12 hours, as defined by `defaultRotationCheckFrequency`. This ensures that rotation checks are performed more frequently. This change improves the responsiveness of the certificate rotation mechanism and allows for quicker detection of expiring certificates. Signed-off-by: d-kuro <[email protected]>
d-kuro
force-pushed
the
d-kuro/fix-default-rotation-check
branch
from
d8f5f7b to
7ea864e
Compare
JaydipGabani
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RotationCheckFrequency was incorrectly defaulting to the same value as the LookaheadInterval (90 days), which is not its intended behavior.
This commit changes the default RotationCheckFrequency to 12 hours, as defined by
defaultRotationCheckFrequency. This ensures that rotation checks are performed more frequently.This change improves the responsiveness of the certificate rotation mechanism and allows for quicker detection of expiring certificates.