forked from isichos/epa
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old Timeseries field with Timeseries model #277
Draft
paulapreuss
wants to merge
13
commits into
main
Choose a base branch
from
feature/implement-timeseries-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replace ts_type with MVS type instead of scalar/vector
15bd995
to
525a701
Compare
a2e3b3c
to
9804746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP for implementing Timeseries
What is done
input_timeseries
data. It should be possible to roll back all of these migrations if necessary.What is not yet working
Timeseries
instance (that was either uploaded or selected before) selected by default. I could not manage to set this up through theinitial
attributes of the form thoughinput_timeseries_old
and create the last necessary migrationIn general, I think there is a lot of "prettier" handling that could be done here, or put in more appropriate places... I saw that the structure you set up is already quite sophisticated and I'm not sure I really got the full extent of it. Feel free to have a look and then we can regroup and talk about it in more detail when I'm back from holiday :).