Feature/add pre commit hook for linting #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t have duplicate and or converging requirements
Bachibouzouk
reviewed
Nov 9, 2022
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| psycopg2-binary==2.9.3 | |||
|
|
|||
| black==19.3b | |||
There was a problem hiding this comment.
Changing black version now will make a huge black diff
There was a problem hiding this comment.
Ok, as we said in #215. Fine with me, if you merge this PR after the workshop :)
|
@Bachibouzouk what is the situation with this PR / issue? I think it would be nice to get the pre-commit hooks set up once before starting back up with development, then it is out of the way :) |
|
Thanks @paulapreuss for taclking this, I think it make sense to tackle precommit at this stage |
|
I think this PR needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on unmerged PR #197.
Closes #215.
@Bachibouzouk, please review this PR and merge on approval. But first, PR #197 needs to be fixed as spoken by you and merged because this PR depends on it.
This PR uses
pre-commitfor installing and managing Git hooks.Initial installation:
pip install (app/)requirements.txtpre-commit installThe config can be found in
.pre-commit-config.yamlin the root folder.Hooks run before every commit.
Run changed files manually:
pre-commitRun all files manually (recommended after installing a new hook):
pre-commitPlease note: I configured that hooks shall fail fast. This can result in running the commit (or pre-commit) multiple times. If we realize that this behavior is different from what we want to see, we can change it in the config in the future.