Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow unique emails for user accounts #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

4lm
Copy link
Collaborator

@4lm 4lm commented Nov 8, 2022

Closes #191.

@Bachibouzouk, please review this fix and merge on approval.

@4lm 4lm requested a review from Bachibouzouk November 8, 2022 11:24
@Bachibouzouk
Copy link

Bachibouzouk commented Nov 9, 2022

@4lm - will this break things in an existing DB? Just want to make sure that I do not messup accounts in the online tool

Edit- It seems fine with my local DB. What would then happen to accounts that do share an email address? Are the surnumerous getting erased?

@4lm
Copy link
Collaborator Author

4lm commented Nov 9, 2022

@4lm - will this break things in an existing DB? Just want to make sure that I do not messup accounts in the online tool

Edit- It seems fine with my local DB. What would then happen to accounts that do share an email address? Are the surnumerous getting erased?

I think the migration (for all accounts) will not happen (it will fail and abort without change) if two accounts use the same email. To fix this, if this case arises, someone would have to manually change the concerning email addresses in the database and re-run the migration.

But the chance that two accounts have the same email is IMO minimal anyway. And if so, are most likely duplicate accounts of the same person who registered twice by accident.

@Bachibouzouk
Copy link

Then I will perform a search if this is the case in the existing database before I merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug, multiple user, same email
2 participants