Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook for linting #215

Open
3 tasks done
4lm opened this issue Nov 8, 2022 · 3 comments · May be fixed by #217
Open
3 tasks done

Add pre-commit hook for linting #215

4lm opened this issue Nov 8, 2022 · 3 comments · May be fixed by #217
Assignees

Comments

@4lm
Copy link
Collaborator

4lm commented Nov 8, 2022

  • add pre-commit hook
  • exclude certain files, e.g. auto-generated migration files
  • homogenize CI workflow with pre-commit hook
@4lm 4lm self-assigned this Nov 8, 2022
@4lm
Copy link
Collaborator Author

4lm commented Nov 8, 2022

Context: I'm running into issues, where I push stuff and the linter rejects it remote, linting should IMO happen also locally before commiting via a pre-commit hook.

@4lm 4lm linked a pull request Nov 8, 2022 that will close this issue
@Bachibouzouk
Copy link

This is not an issue that the linter fails, it has lowest prio over features (especially because changing package now will lead to having to spend time making sure the online tool works well and I don't have that time until the workshop), you will have to live with the uncomfortable feeling of seeing test failing on CI ^^

I will nevertheless merge those changes after the stakeholder workshop

@4lm
Copy link
Collaborator Author

4lm commented Nov 9, 2022

This is not an issue that the linter fails, it has lowest prio over features (especially because changing package now will lead to having to spend time making sure the online tool works well and I don't have that time until the workshop),

OK, thanks for the insides!

you will have to live with the uncomfortable feeling of seeing test failing on CI ^^

Ok, I can live with failing linter + failing unit tests

I will nevertheless merge those changes after the stakeholder workshop

Ok, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants